Skip to content

city-encoding #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2025
Merged

city-encoding #688

merged 3 commits into from
Jan 4, 2025

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jan 4, 2025 •
edited
Loading

fixes #687

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5e98f64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 4, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@688

commit: 5e98f64

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.81% 1804 / 7576
🔵 Statements 23.81% 1804 / 7576
🔵 Functions 57.06% 105 / 184
🔵 Branches 70.91% 451 / 636
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/core/routing/middleware.ts 96.89% 85.29% 50% 96.89% 34-37, 122
packages/open-next/src/overrides/wrappers/cloudflare-edge.ts 0% 100% 100% 0% 8-78
Generated in workflow #855 for commit 5e98f64 by the Vitest Coverage Report Action

@vicb vicb force-pushed the city-encoding branch 2 times, most recently from c3db62d to d654178 Compare January 4, 2025 11:00
conico974
conico974 approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb merged commit 86916bf into main Jan 4, 2025
3 checks passed
@vicb vicb deleted the city-encoding branch January 4, 2025 13:49
@vicb
Copy link
Contributor Author

vicb commented Jan 4, 2025

Thanks for the review

This was referenced Jan 4, 2025
Merged
Open
@workers-frameworks workers-frameworks mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin left review comments

@conico974 conico974 conico974 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: multi-byte characters are not handled correctly in cf geo headers

4 participants

@vicb @petebacondarwin @conico974